fix(table): apply per-task residual filters in ReadTasks - #1676
Draft
fallintoplace wants to merge 2 commits into
Draft
fix(table): apply per-task residual filters in ReadTasks#1676fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the residual filter attached to each scan task when reading tasks.
Why
Manifest planning can produce a residual that is narrower than the scan filter. Ignoring it can return rows that the task was not supposed to read.
What changed
Bind task residuals against the effective schema, use them for projection and row-group pruning, and keep the global scan filter as the fallback. The caller task slice is not modified.
Tests
go test ./table -run TestReadTasksUsesTaskResidual -count=1