fix(table): close stale scan plan IO - #1683
Draft
fallintoplace wants to merge 2 commits into
Draft
Conversation
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close plan-scoped IO when scan planning finishes or a plan is replaced.
Why
Remote replanning and plan-loading errors could leave the previous plan IO open, which leaks resources during retries and failed reads.
What changed
Close local plan IO after planning, close the previous remote plan before replacing it, and close plan IO when ReadTasks fails to load or initialize a plan.
Tests
go test ./table -run TestScanPlanningRemote -count=1go test ./table -run TestReadTasksClosesPlanIOWhenLoadFails -count=1