perf(table): group deletion vector reads by Puffin file - #1764
Closed
fallintoplace wants to merge 1 commit into
Closed
perf(table): group deletion vector reads by Puffin file#1764fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The DV writer stores one blob per data file in a shared Puffin file. The scanner was calling
ReadDVonce per blob, so 100 DVs in one Puffin opened and decoded the same file 100 times.Benchmarks
BenchmarkReadAllDeletionVectorsSharedPuffinon Apple M1 Pro:At 100 DVs, allocations drop from 19.3 MB and 125,737 allocs to 278 KB and 2,793 allocs. The shared Puffin file is opened once instead of 100 times.
Tests
go test ./...go test -race ./table/dv ./table -run "TestReadDV|TestReadDVs|TestReadAllDeletionVectors" -count=1go vet ./...