perf(table): size partition row indices adaptively - #1769
Closed
fallintoplace wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
batch rows / discovered partitionsas the estimate, with a minimum of one.Why
Every new partition currently reserves space for 128 row indexes. This works well for low-cardinality batches, but a batch with one partition per row reserves about 1 KiB for every single row.
The adaptive estimate keeps the current behavior for a few large partitions. It gradually moves toward one row of capacity for high-cardinality batches.
Benchmark
Apple M1 Pro, 32,768 rows, median of 5 runs:
Allocation counts are unchanged in every case. The unique-partition case was also about 14% faster in the repeated comparison.
Tests
go test ./...go test -race ./table -run '^TestFanoutWriter$' -count=1go vet ./...git diff --check