perf(table): stream projected equality deletes - #1774
Closed
fallintoplace wants to merge 1 commit into
Closed
Conversation
fallintoplace
marked this pull request as ready for review
August 12, 2026 08:56
fallintoplace
marked this pull request as draft
August 12, 2026 09:02
fallintoplace
marked this pull request as ready for review
August 12, 2026 10:36
fallintoplace
marked this pull request as draft
August 12, 2026 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ReadTableloaded the full equality delete file before the keys were built. This also loaded columns that were not part of the equality key. Streaming the projected columns lowers peak memory use and avoids that extra work.Checks
go test ./table -count=1go test -race ./table -run "EqualityDelete|ReadEqualityDeleteFile" -count=1go vet ./tableBenchmark
For a 100k-row equality delete file on an Apple M1 Pro: