bug: fix Upsert duplicated rows on partitioned tables - #3780
Open
gabeiglio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3758
Rationale for this change
_build_delete_files_partition_predicatecollectsdata_file.partitionrecords from the deleted files. Those records hold already transformed values, but it passed them toTransaction._build_partition_predicate, which names fields by the source column. So the values gets transformed a second time.Are these changes tested?
Yes added a regression test for upsert.
Are there any user-facing changes?
Yes, it fixes the undefined behavior in upsert