fix: stop calling deprecated PuffinFile.to_vector in Spark DV test - #3804
Open
daviddallakyan2005 wants to merge 1 commit into
Open
fix: stop calling deprecated PuffinFile.to_vector in Spark DV test#3804daviddallakyan2005 wants to merge 1 commit into
daviddallakyan2005 wants to merge 1 commit into
Conversation
This was referenced Aug 16, 2026
ebyhr
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3803
Rationale for this change
Follow-up to #3476.
test_read_spark_written_puffin_dvstill callsPuffinFile.to_vector(), which #3491 deprecated in 0.12.0.filterwarnings = ["error"]turns that into a hard CI failure, sointegration-testis red onmainand on unrelated PRs including #3801.This test now uses
deletion_vectors_from_puffin_file(...), matchingpyiceberg/io/pyarrow.py. Spark interop assertions are unchanged. Not part of #3801.Are these changes tested?
Yes.
make test-integration PYTEST_ARGS="-v -k test_read_spark_written_puffin_dv"→ 1 passed, 5517 deselected.Are there any user-facing changes?
No.