chore: bump MSRV to 1.88, fix warnings and clippy errors #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Contributor
|
Hi, @mbutrovich Thanks for this pr, seems the ci still failed. |
Collaborator
Author
It looked like some of the spurious failures we've been seeing. I updated the branch to include #1900 so we'll see if that helps. |
# Conflicts: # crates/iceberg/src/arrow/record_batch_transformer.rs
Xuanwo
approved these changes
Dec 9, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1899 requires a bump to MSRV 1.88. This version is within the policy of this project, and since the README mentions
MSRV is updated when we release iceberg-rustand we're preparing 0.8, here's a PR for just MSRV 1.88.Which issue does this PR close?
N/A.
What changes are included in this PR?
make check-clippyAre these changes tested?
Existing tests