refactor: Move SensitiveBytes and Credential into shared module - #2971
Open
DerGut wants to merge 5 commits into
Open
refactor: Move SensitiveBytes and Credential into shared module#2971DerGut wants to merge 5 commits into
DerGut wants to merge 5 commits into
Conversation
Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com>
Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com>
Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com>
Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com>
DerGut
force-pushed
the
sensitive-string
branch
from
August 7, 2026 00:17
b706d0b to
bcde3dc
Compare
Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com> Re-generate public API
DerGut
force-pushed
the
sensitive-string
branch
from
August 7, 2026 10:11
bcde3dc to
509cf21
Compare
DerGut
marked this pull request as ready for review
August 7, 2026 10:58
xanderbailey
approved these changes
Aug 8, 2026
xanderbailey
left a comment
Contributor
There was a problem hiding this comment.
This refactor makes sense to me and the import for sensitive bytes is maintained from the encryption mod so I'm happy with this change! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #2972
This is derived from a thread in #2836 (comment) and from @plusplusjiajia's original implementation on #2838. There's three issues I see with the freshly introduced
iceberg::catalog::session::Credentialtype:Credentialalready exists in the context of credential vending (seeiceberg_catalog_rest::StorageCredential- but in Java it's plainCredential). A newCredentialconcept meaning "any sensitive string" conflicts with its3.session-token):iceberg::catalogis the wrong place to share iticeberg::encryption::SensitiveBytestype is located somewhere completely different, making it non-obvious that both exists and share semanticsWhat changes are included in this PR?
This PR moves the recently introduced (and unreleased)
Credentialtype to a separateiceberg::sensitivemodule and colocates it with the existingiceberg::encryption::SensitiveBytes.Are these changes tested?
I added two new tests to assert the redaction behavior of the
SensitiveBytestype and a third test to assert that imports ofSensitiveBytesby its old location remain backwards-compatible.AI Disclosure
I used AI to rubber-duck approaches and rebase my PR onto latest main.