ci: refresh Rust caches on main changes - #3205
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Refreshes trusted Rust caches on main only when relevant inputs change, while keeping PR and merge-queue validation unfiltered.
Changes:
- Adds path-filtered
maintriggers to CI, public API, and Python workflows. - Removes redundant
maintriggers from zizmor and ASF allowlist checks.
File summaries
| File | Summary |
|---|---|
.github/workflows/zizmor.yml |
Removes redundant main push trigger. |
.github/workflows/public-api.yml |
Filters public API cache-refresh runs. |
.github/workflows/ci.yml |
Filters trusted Rust cache-refresh runs. |
.github/workflows/bindings_python_ci.yml |
Filters Python Rust-cache refreshes. |
.github/workflows/asf-allowlist-check.yml |
Removes redundant main push trigger. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
8861d82 to
ad59b4a
Compare
ad59b4a to
481a89a
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Unlike pyiceberg, iceberg-rust hydrates cache using main branch. So we gotta put these main branch triggers back
| push: | ||
| branches: | ||
| - main | ||
| paths: |
There was a problem hiding this comment.
this is same paths filter that was previously removed when we enabled merge queue
| push: | ||
| branches: | ||
| - main | ||
| paths: |
There was a problem hiding this comment.
this is same paths filter that was previously removed when we enabled merge queue
| push: | ||
| branches: | ||
| - main | ||
| paths: |
There was a problem hiding this comment.
this is same paths filter that was previously removed when we enabled merge queue
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
main push trigger is needed to hydrate cache
iceberg-rust/.github/workflows/ci.yml
Line 126 in 29929f6
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
main push trigger is needed to hydrate cache
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
main push trigger is needed to hydrate cache
Our Rust caches are only saved on pushes to
main. After those triggers were removed, PR and merge queue runs could restore old caches, but nothing refreshed them.This restores path-filtered
mainpushes for the three workflows that write Rust caches. PR and merge group triggers stay unfiltered and restore-only.Relates to: #3195, #3203