[Python] add python 3.7 and 3.8 to CI#1369
Merged
rdblue merged 3 commits intoapache:masterfrom Aug 25, 2020
Merged
Conversation
| script: tox | ||
| - language: python | ||
| python: | ||
| - 3.8 |
Member
There was a problem hiding this comment.
If all of these have the same before_scripts can't we just do
python:
-3.6
-3.7
-3.8
before_script:
script:
Contributor
Author
There was a problem hiding this comment.
I thought so as well. Travis seems to only run one python in that case.
Compare yesterdays travis run:
https://travis-ci.org/github/apache/iceberg/builds/720376892
To today's with the duplicate code removed:
https://travis-ci.org/github/apache/iceberg/builds/720565051
Contributor
There was a problem hiding this comment.
It looks fine with all 3 separate, but the 3.8 config lists both 3.6 and 3.7 as well. Should those be removed?
Member
There was a problem hiding this comment.
Travis is a mystery sometimes :) I wouldn't waste time figuring it out since the current version works
added 2 commits
August 24, 2020 08:58
Contributor
|
Thanks @rymurr! Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.