Skip to content

[Python] add python 3.7 and 3.8 to CI #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 3 commits into from
Aug 25, 2020
Merged

[Python] add python 3.7 and 3.8 to CI #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ba2830
add python 3.7 and 3.8 to CI
Aug 23, 2020
16f10fd
simplify travis
Aug 24, 2020
08158e6
revert simplify travis
Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,29 @@ matrix:
directories:
- $HOME/.gradle/caches/
- $HOME/.gradle/wrapper/

- language: python
python: 3.6
python:
- 3.6
before_script:
- cd python
- pip install -e .[dev]
- pip install -U tox-travis
script: tox
- language: python
python:
- 3.7
before_script:
- cd python
- pip install -e .[dev]
- pip install -U tox-travis
script: tox
- language: python
python:
- 3.8
Copy link
Member

@RussellSpitzer RussellSpitzer Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all of these have the same before_scripts can't we just do

python:
 -3.6
 -3.7
 -3.8
before_script:
script:

Copy link
Contributor Author

@rymurr rymurr Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so as well. Travis seems to only run one python in that case.

Compare yesterdays travis run:
https://travis-ci.org/github/apache/iceberg/builds/720376892

To today's with the duplicate code removed:
https://travis-ci.org/github/apache/iceberg/builds/720565051

Copy link
Contributor

@rdblue rdblue Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine with all 3 separate, but the 3.8 config lists both 3.6 and 3.7 as well. Should those be removed?

Copy link
Contributor Author

@rymurr rymurr Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

Copy link
Member

@RussellSpitzer RussellSpitzer Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is a mystery sometimes :) I wouldn't waste time figuring it out since the current version works

before_script:
- cd python
- pip install -e .[dev]
- pip install -U tox-travis
script: tox
deploy:
provider: pypi
Expand Down
8 changes: 7 additions & 1 deletion python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.

[tox]
envlist = py36,linters
envlist = py36,py37,py38,linters

[testenv]
deps =
Expand Down Expand Up @@ -105,3 +105,9 @@ application-import-names = flake8

[pytest]
norecursedirs=.*

[travis]
python =
3.6: py36, linters
3.7: py37
3.8: py38