Skip to content

Data: Add metrics reporter to generic scan builder#16664

Open
alexandrefimov wants to merge 1 commit into
apache:mainfrom
alexandrefimov:add-generics-scan-metrics-reporter
Open

Data: Add metrics reporter to generic scan builder#16664
alexandrefimov wants to merge 1 commit into
apache:mainfrom
alexandrefimov:add-generics-scan-metrics-reporter

Conversation

@alexandrefimov
Copy link
Copy Markdown

@alexandrefimov alexandrefimov commented Jun 2, 2026

This adds a delegating metricsReporter method to IcebergGenerics.ScanBuilder so callers can configure scan metrics reporting without accessing the underlying TableScan directly.

This follows the API shape proposed in #14654, which was closed as stale, and adds focused test coverage for the generic read path.

Closes #14875.

Tests (JDK 21):

  • ./gradlew :iceberg-data:test --tests org.apache.iceberg.data.TestLocalScan.testScanMetricsReporter
  • ./gradlew :iceberg-data:test --tests org.apache.iceberg.data.TestLocalScan
  • ./gradlew :iceberg-data:spotlessCheck
  • ./gradlew :iceberg-data:revapi
  • ./gradlew :iceberg-data:javadoc

@github-actions github-actions Bot added the data label Jun 2, 2026
@alexandrefimov
Copy link
Copy Markdown
Author

The only failing check is core-tests (17), caused by the known flaky TestHadoopCommits > testConcurrentFastAppends(File) timeout. Could someone with permissions please rerun the failed job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Allow callers to configure metrics reporter on ScanBuilder

1 participant