Skip to content

Data: Add metrics reporter to generic scan builder #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandrefimov wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

Data: Add metrics reporter to generic scan builder #16664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.apache.iceberg.TableScan;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.io.CloseableIterable;
import org.apache.iceberg.metrics.MetricsReporter;

public class IcebergGenerics {
private IcebergGenerics() {}
Expand Down Expand Up @@ -96,6 +97,11 @@ public ScanBuilder appendsAfter(long fromSnapshotId) {
return this;
}

public ScanBuilder metricsReporter(MetricsReporter reporter) {
this.tableScan = tableScan.metricsReporter(reporter);
return this;
}

public CloseableIterable<Record> build() {
return new TableScanIterable(tableScan, reuseContainers);
}
Expand Down
19 changes: 19 additions & 0 deletions data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@
import org.apache.iceberg.expressions.Expressions;
import org.apache.iceberg.hadoop.HadoopInputFile;
import org.apache.iceberg.hadoop.HadoopTables;
import org.apache.iceberg.io.CloseableIterable;
import org.apache.iceberg.io.DataWriter;
import org.apache.iceberg.metrics.InMemoryMetricsReporter;
import org.apache.iceberg.metrics.ScanReport;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
Expand Down Expand Up @@ -289,6 +292,22 @@ public void testFullScan() {
assertThat(records).as("Random record set should match").isEqualTo(expected);
}

@TestTemplate
public void testScanMetricsReporter() throws IOException {
InMemoryMetricsReporter reporter = new InMemoryMetricsReporter();

try (CloseableIterable<Record> results =
IcebergGenerics.read(sharedTable).metricsReporter(reporter).build()) {
assertThat(Sets.newHashSet(results)).hasSize(9);
}

ScanReport scanReport = reporter.scanReport();
assertThat(scanReport).isNotNull();
assertThat(scanReport.tableName()).isEqualTo(sharedTable.name());
assertThat(scanReport.snapshotId()).isEqualTo(sharedTable.currentSnapshot().snapshotId());
assertThat(scanReport.scanMetrics().resultDataFiles().value()).isEqualTo(3);
}

@TestTemplate
public void testFilter() {
Iterable<Record> result = IcebergGenerics.read(sharedTable).where(lessThan("id", 3)).build();
Expand Down
Loading