Flink 1.20, 2.0: Fix file offset mismatch in DataIterator.seek() when files are skipped#16950
Merged
pvary merged 1 commit intoJun 25, 2026
Conversation
… files are skipped Port of apache#16929 (Flink 2.1) to Flink 1.20 and Flink 2.0. DataIterator.seek() overwrites fileOffset after updateCurrentIterator() has correctly advanced it past files skipped by residual filters. This causes checkpoint to record a wrong file offset, leading to duplicate consumption or IllegalStateException on recovery. The fix: 1. Increment fileOffset in the skip-files loop so it tracks position as files are skipped 2. Remove the incorrect fileOffset/recordOffset assignments at the end of seek() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wombatu-kun
approved these changes
Jun 25, 2026
pvary
approved these changes
Jun 25, 2026
Contributor
|
Merged to main. |
zhongyujiang
deleted the
fix/flink-data-iterator-file-offset-mismatch-other-versions
branch
jakelong95
pushed a commit
to jakelong95/iceberg
that referenced
this pull request
Jun 29, 2026
…files are skipped (apache#16950) Backports apache#16929
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #16929 to Flink 1.20 and Flink 2.0.
cc @pvary Could you please review?