API: Fix incorrect Javadoc on ManageSnapshots tag methods - #17243
Merged
singhpk234 merged 1 commit intoJul 18, 2026
Conversation
createTag's @param snapshotId said "head of the new branch" and removeTag's @throws said "if the branch does not exist". Both are copy-paste leftovers from the sibling branch methods; corrected to refer to the tag. Generated-by: Claude Code
ebyhr
approved these changes
Jul 16, 2026
singhpk234
approved these changes
Jul 18, 2026
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @thswlsqls for change and @ebyhr for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTag(String, long):@param snapshotIdsaid "head of the new branch"; corrected to "tag".removeTag(String):@throws IllegalArgumentExceptionsaid "if the branch does not exist"; corrected to "tag".createBranch(String, long)andremoveBranch(String)Javadoc, which are the correct anchors.Testing done
./gradlew :iceberg-api:spotlessCheckpassed.