Common: Fix copy-pasted Javadoc referring to methods in DynFields - #17244
Draft
thswlsqls wants to merge 1 commit into
Draft
Common: Fix copy-pasted Javadoc referring to methods in DynFields#17244thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
DynFields was copied from DynMethods, but several Javadoc comments kept DynMethods terms. They described method/BoundMethod/NoSuchMethodException and receiver where the code returns BoundField, throws NoSuchFieldException, and binds to a target field. Correct the wording to match the signatures. Generated-by: Claude Code
thswlsqls
marked this pull request as draft
July 17, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynFieldswas copied fromDynMethods, and several Javadoc comments kept the originalDynMethodswording.java.lang.reflect.Field.bind(Object),buildChecked(Object)andbuild(Object)said they return aBoundMethod; they return aBoundField.buildChecked(Object)said it throwsNoSuchMethodException; its signature throwsNoSuchFieldException.@throwsand@paramtext said "method"/"receiver" where the code binds a field to a target, andasStatic()/buildStatic()said "if the method is not static".DynMethodsthe comments came from shows the correct terms. Javadoc-only, no signature or bytecode change.Testing done
./gradlew :iceberg-common:spotlessApply :iceberg-common:spotlessCheck— BUILD SUCCESSFUL (JDK 21).AI Disclosure