Docs: Clarify snapshot summary's "total-records" description - #17318
Open
ldudas-marx wants to merge 1 commit into
Open
Docs: Clarify snapshot summary's "total-records" description#17318ldudas-marx wants to merge 1 commit into
ldudas-marx wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Specification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the name "total-records" field's description is very ambiguous. The naive reader could think that this is the number of active rows in the table. But it contains all the deleted rows too. There have already been cases where it caused confusion (#6709, #12823).