Skip to content

Build: make JMH harness JDK 17-clean (module opens, configurable heap, failOnError) #17331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaquarkhan wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −2
Open

Build: make JMH harness JDK 17-clean (module opens, configurable heap, failOnError) #17331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions jmh.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,33 @@ configure(jmhProjects) {

jmh {
jmhVersion = '1.37'
failOnError = true
// Was hard-coded true; one failing param combination aborted the whole suite and discarded
// already-completed results. Make it configurable, default preserved.
failOnError = project.hasProperty('jmhFailOnError') ? project.property('jmhFailOnError').toBoolean() : true
forceGC = true
includeTests = true
humanOutputFile = file(jmhOutputPath)
jvmArgs = ['-Xmx32g']
// Configurable heap (default preserved at 32g); full-scale PlanningBenchmark ...WithStats OOMs at 32g.
// Plus the JDK 17 module opens Spark 4.x needs (sun.util.calendar for date conversion, etc.).
jvmArgs = [
'-Xmx' + (project.findProperty('jmhHeap') ?: '32g'),
'-XX:+IgnoreUnrecognizedVMOptions',
'--add-opens=java.base/java.lang=ALL-UNNAMED',
'--add-opens=java.base/java.lang.invoke=ALL-UNNAMED',
'--add-opens=java.base/java.lang.reflect=ALL-UNNAMED',
'--add-opens=java.base/java.io=ALL-UNNAMED',
'--add-opens=java.base/java.net=ALL-UNNAMED',
'--add-opens=java.base/java.nio=ALL-UNNAMED',
'--add-opens=java.base/java.util=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent=ALL-UNNAMED',
'--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED',
'--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED',
'--add-opens=java.base/sun.nio.ch=ALL-UNNAMED',
'--add-opens=java.base/sun.nio.cs=ALL-UNNAMED',
'--add-opens=java.base/sun.security.action=ALL-UNNAMED',
'--add-opens=java.base/sun.util.calendar=ALL-UNNAMED',
'--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED'
]
resultsFile = file(jmhJsonOutputPath)
resultFormat = 'JSON'
includes = [jmhIncludeRegex]
Expand Down
Loading