Skip to content

Parquet: Add round-trip test for encrypted shredded variant columns - #17469

Merged
huaxingao merged 3 commits into
apache:mainfrom
nssalian:encryption-variant-shredding-test
Aug 3, 2026
Merged

Parquet: Add round-trip test for encrypted shredded variant columns#17469
huaxingao merged 3 commits into
apache:mainfrom
nssalian:encryption-variant-shredding-test

Conversation

@nssalian

@nssalian nssalian commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Rationale

Existing tests cover shredding and encryption separately, not together. Adding this to clarify the encryption behavior on a shredded variant.

Changes

  • Adds a test covering a shredded variant column written to an encrypted Parquet file: no-key read fails, keyed read round-trips, and the decrypted footer confirms the shredded layout. Test-only.
  • Cleaned up some of the common artifacts into helpers from the previous tests so we don't have to duplicate.

@nssalian
nssalian marked this pull request as ready for review August 2, 2026 02:39
@nssalian
nssalian requested a review from huaxingao August 2, 2026 02:40
wombatu-kun
wombatu-kun reviewed Aug 2, 2026
View reviewed changes
Comment thread parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java Outdated
Comment thread parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java Outdated
wombatu-kun
wombatu-kun reviewed Aug 2, 2026
View reviewed changes
Comment thread parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java Outdated
Comment thread parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java Outdated
Comment thread parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java Outdated
@nssalian

nssalian commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the reviews @wombatu-kun. I cleaned up these tests and some of the older ones in the file too so we reuse with helpers.

@uros-b

uros-b commented Aug 2, 2026

Copy link
Copy Markdown
Member

Thank you @nssalian and @wombatu-kun!

@nssalian

nssalian commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

CC: @ggershinsky PTAL when you can

ggershinsky
ggershinsky approved these changes Aug 3, 2026
View reviewed changes

@ggershinsky ggershinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

huaxingao
huaxingao approved these changes Aug 3, 2026
View reviewed changes

@huaxingao huaxingao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao
huaxingao merged commit b289a90 into apache:main Aug 3, 2026
38 checks passed
@huaxingao

huaxingao commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Thanks @nssalian for the PR! Thanks everyone for the review!

@nssalian
nssalian deleted the encryption-variant-shredding-test branch August 3, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huaxingao huaxingao huaxingao approved these changes
+4 more reviewers
@ggershinsky ggershinsky ggershinsky approved these changes
@wombatu-kun wombatu-kun wombatu-kun approved these changes
@vishnuprakaz vishnuprakaz vishnuprakaz approved these changes
@uros-b uros-b uros-b approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

parquet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nssalian @uros-b @huaxingao @ggershinsky @wombatu-kun @vishnuprakaz