Skip to content

Core: Fix a typo in the comment - #17503

Merged
kevinjqliu merged 1 commit into
apache:mainfrom
hsiang-c:obj_store_table_prop_typo
Aug 4, 2026
Merged

Core: Fix a typo in the comment#17503
kevinjqliu merged 1 commit into
apache:mainfrom
hsiang-c:obj_store_table_prop_typo

Conversation

@hsiang-c

@hsiang-c hsiang-c commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

In ObjectStoreLocationProvider, the property is used to include partition paths instead of excluding them.

      this.includePartitionPaths =
          PropertyUtil.propertyAsBoolean(
              properties,
              TableProperties.WRITE_OBJECT_STORE_PARTITIONED_PATHS,
              TableProperties.WRITE_OBJECT_STORE_PARTITIONED_PATHS_DEFAULT);

@github-actions github-actions Bot added the core label Aug 3, 2026
dramaticlly
dramaticlly approved these changes Aug 4, 2026
View reviewed changes
Comment thread core/src/main/java/org/apache/iceberg/TableProperties.java
public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;

// Excludes the partition values in the path when set to true and object store is enabled
// Includes the partition values in the path when set to true and object store is enabled

@dramaticlly dramaticlly Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the current documentation is simpler, we can probably get rid of it entirely as code to use is self-explanatory.

iceberg/docs/docs/configuration.md

Line 88 in 58d5c37

| write.object-storage.partitioned-paths | true | Includes the partition values in the file path |

kevinjqliu
kevinjqliu approved these changes Aug 4, 2026
View reviewed changes

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From the original PR:
ea5da17#diff-6f2156400fa35debca4830447335d157ae330b05011d6037f6c4cde725b2add7R130-R134

@kevinjqliu
kevinjqliu merged commit 949d47a into apache:main Aug 4, 2026
37 checks passed
@hsiang-c
hsiang-c deleted the obj_store_table_prop_typo branch August 4, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinjqliu kevinjqliu kevinjqliu approved these changes
+3 more reviewers
@dramaticlly dramaticlly dramaticlly approved these changes
@ebyhr ebyhr ebyhr approved these changes
@uros-b uros-b uros-b approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hsiang-c @dramaticlly @ebyhr @kevinjqliu @uros-b