fix: use writeFixed instead of writeBytes for FixedByteBufferWriter - #17505
Open
waterWang wants to merge 1 commit into
Open
fix: use writeFixed instead of writeBytes for FixedByteBufferWriter#17505waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
3 tasks
uros-b
reviewed
Aug 4, 2026
uros-b
left a comment
Member
There was a problem hiding this comment.
@waterWang Please note that this may have already been covered in #17502. cc @DuanRuixiao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix:
FixedByteBufferWriteruseswriteBytesinstead ofwriteFixedfor Avrofixed[N]fieldsFixes #17501
Problem
ValueWriters.FixedByteBufferWriter.write(ByteBuffer, Encoder)callsencoder.writeBytes(bytes)instead ofencoder.writeFixed(bytes). For Avrofixed[N]fields this is wrong:writeBytesprepends a zigzag-encoded length prefix before the data, but the Avro reader consumes exactly N bytes for afixedfield and has no length prefix to skip. The stray prefix byte spills into the next field in the record.Fix
Convert the
ByteBufferto abyte[]and callencoder.writeFixed(arr)instead.Testing
Existing tests for
fixed[N]fields withByteBuffervalues should now pass without corruption. The sibling classFixedWriter(which handlesbyte[]) already useswriteFixedcorrectly.