Core, Flink, Spark, Build: Replace Guava Queues with plain JDK and bump guava from 33.6.0-jre to 33.7.1-jre - #17888
Merged
huaxingao merged 2 commits intoSep 4, 2026
Conversation
Bumps `guava` from 33.6.0-jre to 33.7.1-jre. Updates `com.google.guava:guava` from 33.6.0-jre to 33.7.1-jre - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Updates `com.google.guava:guava-testlib` from 33.6.0-jre to 33.7.1-jre - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-version: 33.7.1-jre dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.guava:guava-testlib dependency-version: 33.7.1-jre dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ebyhr
force-pushed
the
ebi/dependabot/gradle/guava-33.7.1-jre
branch
from
August 30, 2026 05:19
9c7dffd to
3aae8d5
Compare
uros-b
approved these changes
Aug 30, 2026
Member
|
LGTM, thank you @ebyhr! |
singhpk234
approved these changes
Aug 31, 2026
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @ebyhr !
huaxingao
approved these changes
Sep 1, 2026
Contributor
|
Thanks @ebyhr for the PR! Thanks @uros-b @singhpk234 for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependabot bump of Guava 33.6.0 → 33.7.1 broke compilation:
iceberg-bundled-guavashades Guava viashadowJar+minimize(). Since that module has no consumers on its own classpath,minimize()only keeps a class if something else inside Guava still references it.Queuessurvived only becauseMoreExecutorscalledQueues.newLinkedBlockingQueue()internally. Guava 33.7.x replaced that internal call withnew LinkedBlockingQueue<>(), sominimize()now seesQueuesas unused and strips it even thoughcore,flink, andsparkcall it directly at runtime.Excluding
guavafromminimize()keepsQueues, but also restores unrelocatedcom.google.thirdparty.publicsuffix.*classes.This PR removes the dependency on the shaded Queues helper entirely. Its methods are one-line wrappers around JDK constructors:
Closes #17882