Build: workflows cache gradle wrapper#4165
Merged
rdblue merged 1 commit intoapache:masterfrom Sep 29, 2022
Merged
Conversation
rdblue
approved these changes
Feb 20, 2022
Contributor
rdblue
left a comment
There was a problem hiding this comment.
Looks good to me when tests are passing.
Contributor
|
Failed spark test looks rather unrelated |
nastra
approved these changes
Feb 21, 2022
Contributor
Author
|
Tests seem to be passing, so should this be merged? |
0642476 to
19e493c
Compare
Contributor
Author
|
rebased due to merge conflict |
19e493c to
aa8b567
Compare
aa8b567 to
15197c9
Compare
Contributor
Author
|
rebased in case we still want to do t his |
Contributor
Author
|
note that these alternatives exist: |
rdblue
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoids downloading the gradle distribution on every workflow run
also follows the recommended usage pattern for the github action:
https://github.com/actions/cache/blob/main/examples.md#java---gradle
the folder contents are deterministic: