fix(docs): make Node SDK quickstart and examples runnable (closes #51) - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node quickstart sent to a stream and topic it never created, so it failed
immediately on a fresh server.
Both pages now:
are repeatable
Partitioning.Balancedinstead of indexingtopic.partitions, which isabsent from the object
topic.listreturns even thoughtopic.createincludes it
PollingStrategy.Nextandautocommit: true, so consecutive runsread successive batches instead of repeating the first ten
partitionIdfrom 1 to 0client.destroy()Verified against
apache/iggy:edge: producer twice, consumer twice, second runpicking up the next batch.
AI was used to help draft this. Reviewed and tested by a real human.