Follow-up from the experimental PHP SDK review.
foreign/php/tests/TlsTest.php skips its TLS tests whenever IGGY_TLS_CONNECTION_STRING is unset, and the PHP pre-merge workflow never sets it. As a result, the PHP TLS tests are currently dead in CI.
Scope
Mirror the node pre-merge action's TLS setup for the PHP action:
- Start a second Iggy server for the TLS suite with
IGGY_TCP_TLS_ENABLED=true.
- Export
IGGY_TLS_CONNECTION_STRING for the PHP tests.
- Run the PHP TLS test suite against that TLS-enabled server.
- Stop the TLS server after the suite completes.
- Keep the existing plain TCP PHP test path intact.
Files of interest
.github/actions/php/pre-merge/action.ymlforeign/php/tests/TlsTest.php.github/actions/node-npm/pre-merge/action.yml as the reference pattern
Related: #3302
Initial PHP SDK work: #3235
Follow-up from the experimental PHP SDK review.
foreign/php/tests/TlsTest.phpskips its TLS tests wheneverIGGY_TLS_CONNECTION_STRINGis unset, and the PHP pre-merge workflow never sets it. As a result, the PHP TLS tests are currently dead in CI.Scope
Mirror the node pre-merge action's TLS setup for the PHP action:
IGGY_TCP_TLS_ENABLED=true.IGGY_TLS_CONNECTION_STRINGfor the PHP tests.Files of interest
.github/actions/php/pre-merge/action.ymlforeign/php/tests/TlsTest.php.github/actions/node-npm/pre-merge/action.ymlas the reference patternRelated: #3302
Initial PHP SDK work: #3235