Skip to content

ci(php): run TLS tests in CI#3381

Merged
hubcio merged 2 commits into
apache:masterfrom
WaterWhisperer:ci/php-tls-tests
Jun 2, 2026
Merged

ci(php): run TLS tests in CI#3381
hubcio merged 2 commits into
apache:masterfrom
WaterWhisperer:ci/php-tls-tests

Conversation

@WaterWhisperer
Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Closes #3308

Rationale

PHP SDK TLS tests were not exercised because CI only started a plain TCP server and did not set the TLS test environment variables.

What changed?

The test task now stops the plain server, starts Iggy with TCP TLS enabled and project certificates, and runs tests/TlsTest.php with the TLS connection environment configured.

Local Execution

  • Passed
  • Pre-commit hooks ran
  • Docker PHP 8.3.31 dynamic verification with the full plain PHP SDK suite and TLS tests

AI Usage

  1. Tools: Codex.
  2. Scope of usage: inspect the existing PHP SDK TLS tests, adjust the test assertions
  3. Verification: ran PHP 8.3 Docker dynamic tests
  4. Yes

@github-actions
Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.62%. Comparing base (a8dd3a9) to head (c56b0e0).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3381      +/-   ##
============================================
- Coverage     74.65%   74.62%   -0.03%     
  Complexity      943      943              
============================================
  Files          1228     1228              
  Lines        120529   120529              
  Branches      97263    97294      +31     
============================================
- Hits          89975    89948      -27     
+ Misses        27614    27606       -8     
- Partials       2940     2975      +35     
Components Coverage Δ
Rust Core 75.84% <ø> (-0.01%) ⬇️
Java SDK 58.44% <ø> (ø)
C# SDK 69.41% <ø> (-0.45%) ⬇️
Python SDK 81.06% <ø> (ø)
Node SDK 91.53% <ø> (ø)
Go SDK 40.20% <ø> (ø)
see 26 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented Jun 1, 2026

@countradooku mind checking this?

@countradooku
Copy link
Copy Markdown
Contributor

@countradooku mind checking this?

I will

@countradooku
Copy link
Copy Markdown
Contributor

Looks good

@hubcio hubcio merged commit d94cad8 into apache:master Jun 2, 2026
89 checks passed
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Jun 2, 2026
@WaterWhisperer WaterWhisperer deleted the ci/php-tls-tests branch June 2, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP SDK: run TLS tests in CI

4 participants