ci(php): run TLS tests in CI#3381
Merged
Merged
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3381 +/- ##
============================================
- Coverage 74.65% 74.62% -0.03%
Complexity 943 943
============================================
Files 1228 1228
Lines 120529 120529
Branches 97263 97294 +31
============================================
- Hits 89975 89948 -27
+ Misses 27614 27606 -8
- Partials 2940 2975 +35
🚀 New features to boost your workflow:
|
Contributor
|
@countradooku mind checking this? |
Contributor
I will |
Contributor
|
Looks good |
hubcio
approved these changes
Jun 2, 2026
spetz
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3308
Rationale
PHP SDK TLS tests were not exercised because CI only started a plain TCP server and did not set the TLS test environment variables.
What changed?
The test task now stops the plain server, starts Iggy with TCP TLS enabled and project certificates, and runs
tests/TlsTest.phpwith the TLS connection environment configured.Local Execution
AI Usage