fix(connectors): unify extract_column_value into single free function#3199
Open
atharvalade wants to merge 1 commit intoapache:masterfrom
Open
fix(connectors): unify extract_column_value into single free function#3199atharvalade wants to merge 1 commit intoapache:masterfrom
atharvalade wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
=============================================
- Coverage 74.10% 19.21% -54.89%
Complexity 943 943
=============================================
Files 1159 1157 -2
Lines 102033 90323 -11710
Branches 79083 67391 -11692
=============================================
- Hits 75607 17356 -58251
- Misses 23765 72553 +48788
+ Partials 2661 414 -2247
🚀 New features to boost your workflow:
|
022bacc to
6a3e441
Compare
6a3e441 to
08153c5
Compare
Contributor
|
@atharvalade Also remeber about #3196 where you also add Date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3172
Rationale
Bug fixes or new type support added to one copy of
extract_column_valuesilently won't apply to the other, causing divergence between sequential and parallel code paths.What changed?
The Postgres source connector had
extract_column_valueas a method onPostgresSource(&self), making it impossible to call from static/parallel contexts without duplicating the function. Any future parallel/chunked path would need its own copy.Converted it to a single free function callable from any context. Added missing
DATE(viachrono::NaiveDate) andBPCHARtype handling that the parallel copy on the benchmark branch had but this version lacked.Local Execution
AI Usage