fix(integration): fix partitions,permissions integration tests - #3487
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (19.58%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3487 +/- ##
============================================
- Coverage 74.70% 74.21% -0.49%
Complexity 937 937
============================================
Files 1258 1259 +1
Lines 125131 125969 +838
Branches 100805 101688 +883
============================================
+ Hits 93475 93490 +15
- Misses 28658 29418 +760
- Partials 2998 3061 +63
🚀 New features to boost your workflow:
|
|
/ready |
|
/ready |
hubcio
left a comment
There was a problem hiding this comment.
a few findings land on code this PR didn't change, so they're here rather than as line comments:
-
core/sdk/src/websocket/websocket_client.rs(around 700-716): the WS vsrsend_rawreads the response header and body with no timeout while holding thestreamlock, which is the exact lockstep wedge the TCP client just got fixed (RESPONSE_READ_TIMEOUTplus drop-on-timeout). if the server loses a reply the WS client hangs forever. the newsdk/messages.rstest runs over WebSocket too, so this path is now exercised. it's actually worse than the old TCP case - the WS read runs in the caller's task, not a spawned one, so there's no post-task stream drop. mirror the TCP timeout plus stream-drop on WS (and check QUIC). -
core/server-ng/src/responses.rs:294and:597: thePOLL_MESSAGESarm inbuild_non_replicated_responseand theNonReplicatedResponse::EmptyPolledMessagesvariant look dead now -handle_poll_messageshas its own explicit dispatch arm, so the fallback never reaches POLL. ~15 lines plus a never-served empty-poll path can go. -
core/server_common/src/send_messages2.rs:465:owned_messageis#[allow(dead_code)]with zero callers, and it happens to be the one place with the correct flat-base_timestampreconstruction. either wire it intobuild_polled_messages_body(which would also fix the timestamp bug) or delete it.
|
/ready |
|
/ready |
Fixes integration tests for
partitions(excluding those that useconsumer_group) & permissions auth tests.