ci(rust): skip unnecessary setup steps - #3749
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3749 +/- ##
============================================
- Coverage 75.86% 75.80% -0.07%
Complexity 969 969
============================================
Files 1323 1323
Lines 160111 160111
Branches 133501 133576 +75
============================================
- Hits 121476 121376 -100
- Misses 34993 35005 +12
- Partials 3642 3730 +88
🚀 New features to boost your workflow:
|
b089984 to
4526ce8
Compare
|
The cpp bdd failure looks like a transient network failure |
|
very nice! i'll review this today |
hubcio
left a comment
There was a problem hiding this comment.
the direction here is good, and the PR closes a real pre-existing hole worth naming: previously test-1 and test-2 each ran their own git fetch origin master and cargo rail plan, so two racing fetches could resolve different origin/master, produce different -E filters, and let a test fall out of both partitions. one build shipping a single nextest-filter.txt makes the partitions complementary by construction.
one blocker, on the artifact name - see the comment at line 323 of the composite action. everything else is should-fix or polish.
one finding lands outside the diff so it has no line to attach to: Install cargo-nextest in setup-rust-with-cache still carries continue-on-error: true, but this PR deletes the cargo test fallback that made a missing nextest survivable. a curl flake now shows a green setup step and dies several steps later at cargo nextest archive with "no such command: nextest". the flag has outlived its reason - worth dropping while you're in there.
|
/ready |
|
@Standing-Man something is still wrong: it's building /author |
|
overall i'm happy with the speedup itself, but i still don't like this skipped jobs noise: @Standing-Man could you please think of restructuring the code so that we would cut this noise? can be done in in next PR / future. |
|
I took a peek at CI logs. why are we uploading something to codecov in job |
8d59811
Signed-off-by: StandingMan <jmtangcs@gmail.com>



Rationale
Rust CI was doing redundant work in two areas:
cargo macheteinstalled nextest and system dependencies that theydid not use.
This increased both CI setup time and total compute usage.
What changed?
platform-specific system dependencies.
Results
The setup optimization was measured over three runs:
A pre-merge comparison showed:
The benchmark link.
Local Execution
Passed
Ran
AI Usage