Skip to content

IGNITE-18180 RocksDB partition deletion operation completed - #1505

Merged
ibessonov merged 7 commits into
apache:mainfrom
gridgain:ignite-18180
Jan 10, 2023
Merged

IGNITE-18180 RocksDB partition deletion operation completed#1505
ibessonov merged 7 commits into
apache:mainfrom
gridgain:ignite-18180

Conversation

@ibessonov

Copy link
Copy Markdown
Contributor

Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
);

/** Thread-local write batch for {@link #runConsistently(WriteClosure)}. */
private final ThreadLocal<WriteBatchWithIndex> threadLocalWriteBatch = new ThreadLocal<>();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not static ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static would not allow us to operate with multiple partitions from the same thread. No one would do that, but technically non-static field is a correct solution here

Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
@ibessonov
ibessonov merged commit 896acf6 into apache:main Jan 10, 2023
@ibessonov
ibessonov deleted the ignite-18180 branch January 10, 2023 11:24
maxzhuravkov pushed a commit to gridgain/apache-ignite-3 that referenced this pull request Mar 18, 2023
maxzhuravkov pushed a commit to gridgain/apache-ignite-3 that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants