IGNITE-18850 Add ssl configuration validation - #1738
Merged
Conversation
PakhomovAlexander
left a comment
PakhomovAlexander
left a comment
Contributor
There was a problem hiding this comment.
Have you tested the patch manually or with integration tests?
| @Test | ||
| public void emptyTrustStorePath(@TempDir Path tmpDir) throws IOException { | ||
| validate(createTrustStoreConfig(tmpDir, "PKCS12", "", "changeIt"), | ||
| "Key store path must not be blank"); |
Contributor
There was a problem hiding this comment.
I think it is better to print trust store in those cases, not key store.
Contributor
Author
Not sure what do you mean, integration tests were run during the check. |
# Conflicts: # modules/rest/src/main/java/org/apache/ignite/internal/rest/RestComponent.java # modules/rest/src/test/java/org/apache/ignite/internal/rest/RestComponentTest.java
# Conflicts: # modules/rest/src/main/java/org/apache/ignite/internal/rest/RestComponent.java
ibessonov
reviewed
Mar 6, 2023
| */ | ||
| public class SslConfigurationValidatorImpl implements Validator<SslConfigurationValidator, SslView> { | ||
|
|
||
| public static final SslConfigurationValidatorImpl INSTANCE = new SslConfigurationValidatorImpl(); |
Contributor
There was a problem hiding this comment.
I never understood, why do we need a static instance. I understand that you just replicated the approach, but nonetheless, I'm curious
ibessonov
approved these changes
Mar 6, 2023
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Feb 4, 2025
Bumps org.gridgain:gridgain-core from 8.9.15 to 8.9.17. --- updated-dependencies: - dependency-name: org.gridgain:gridgain-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com> Co-authored-by: Aleksandr Polovtsev <alex.polovtcev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-18850