IGNITE-19039 Fix PlatformTestNodeRunner SSL config on Windows - #1794
Merged
Conversation
sashapolo
reviewed
Mar 15, 2023
| } | ||
|
|
||
| /** | ||
| * Converts an URL gotten from classloader to proper file system path. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Converts an URL gotten from classloader to proper file system path. | |
| * Converts a URL to a file system path. |
| */ | ||
| public static String getResourcePath(URL url) { | ||
| try { | ||
| Objects.requireNonNull(url); |
Contributor
There was a problem hiding this comment.
I think this check is redundant
| * @param resourceName A resource name. | ||
| * @return A file system path matching the path component of the resource URL. | ||
| */ | ||
| public static <T> String getResourcePath(Class<T> cls, String resourceName) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public static <T> String getResourcePath(Class<T> cls, String resourceName) { | |
| public static String getResourcePath(Class<?> cls, String resourceName) { |
| } | ||
|
|
||
| /** | ||
| * Adds escape characters before backslashes in a path (on Windows), e.g. for the HOCON config parser. |
Contributor
There was a problem hiding this comment.
Can you please provide an example, how this method will transform a given string?
sashapolo
approved these changes
Mar 15, 2023
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.