IGNITE-19014 Topology aware Raft client creates its own message handler which is not aware of Raft group - #1796
Merged
Merged
Conversation
vldpyatkov
reviewed
Mar 16, 2023
| /** Leader election handler. */ | ||
| private final ServerEventHandler serverEventHandler; | ||
|
|
||
| private final BiConsumer<ClusterNode, Long> leaderElectionListener; |
Contributor
There was a problem hiding this comment.
This property is excess.
| ) | ||
| ); | ||
|
|
||
| RaftGroupEventsClientListener raftGroupEventsClientListener = new RaftGroupEventsClientListener(); |
Contributor
There was a problem hiding this comment.
As we discussed before, TODO here is required, to move the property to a factory for various types of clients.
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
…er which is not aware of Raft group (apache#1796)
maxzhuravkov
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
…er which is not aware of Raft group (apache#1796)
isapego
pushed a commit
to isapego/ignite-3
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19014