Skip to content

IGNITE-28504 Remove mentions of IGNITE-26358 in code#7967

Merged
isapego merged 1 commit intoapache:mainfrom
isapego:ignite-28504
Apr 13, 2026
Merged

IGNITE-28504 Remove mentions of IGNITE-26358 in code#7967
isapego merged 1 commit intoapache:mainfrom
isapego:ignite-28504

Conversation

@isapego
Copy link
Copy Markdown
Contributor

@isapego isapego commented Apr 10, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy references to IGNITE-26358 in the Python DB-API test suite and re-enables/extends several test scenarios that were previously disabled or commented out.

Changes:

  • Unskips the SSL multi-page fetch test that was previously marked flaky.
  • Expands fetch-table pagination coverage to include a larger row count (8000).
  • Expands executemany coverage to include larger batch sizes (300 and 2000).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
modules/platforms/python/dbapi/tests/test_ssl.py Removes IGNITE-26358 TODO/skip and re-enables the SSL fetch paging test.
modules/platforms/python/dbapi/tests/test_fetch_table.py Removes IGNITE-26358 TODO and adds a larger row-count case to pagination testing.
modules/platforms/python/dbapi/tests/test_executemany.py Removes IGNITE-26358 TODO and adds larger batch sizes to executemany parametrization.
Comments suppressed due to low confidence (1)

modules/platforms/python/dbapi/tests/test_ssl.py:105

  • This test was previously skipped as flaky due to missing heartbeats, but it is now unskipped without any explicit heartbeat configuration. To avoid reintroducing that flakiness (and to stay consistent with tests/conftest.py which sets heartbeat_interval=2), consider passing a small heartbeat_interval explicitly in this SSL connect call, or reintroducing a skip/xfail with a concrete stability condition if it’s still intermittent.
@pytest.mark.parametrize("address", [server_addresses_ssl_basic, server_addresses_ssl_client_auth])
def test_fetch_table_several_pages(table_name, address, drop_table_cleanup):
    ssl_cfg = create_ssl_param(True, 'client.pem', 'client.pem', 'ca.pem')
    with pyignite_dbapi.connect(address=address, timeout=10, **ssl_cfg) as connection:
        with connection.cursor() as cursor:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@isapego isapego merged commit d3f1e9b into apache:main Apr 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants