IGNITE-28504 Remove mentions of IGNITE-26358 in code#7967
Merged
isapego merged 1 commit intoapache:mainfrom Apr 13, 2026
Merged
IGNITE-28504 Remove mentions of IGNITE-26358 in code#7967isapego merged 1 commit intoapache:mainfrom
isapego merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy references to IGNITE-26358 in the Python DB-API test suite and re-enables/extends several test scenarios that were previously disabled or commented out.
Changes:
- Unskips the SSL multi-page fetch test that was previously marked flaky.
- Expands fetch-table pagination coverage to include a larger row count (8000).
- Expands
executemanycoverage to include larger batch sizes (300 and 2000).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/platforms/python/dbapi/tests/test_ssl.py | Removes IGNITE-26358 TODO/skip and re-enables the SSL fetch paging test. |
| modules/platforms/python/dbapi/tests/test_fetch_table.py | Removes IGNITE-26358 TODO and adds a larger row-count case to pagination testing. |
| modules/platforms/python/dbapi/tests/test_executemany.py | Removes IGNITE-26358 TODO and adds larger batch sizes to executemany parametrization. |
Comments suppressed due to low confidence (1)
modules/platforms/python/dbapi/tests/test_ssl.py:105
- This test was previously skipped as flaky due to missing heartbeats, but it is now unskipped without any explicit heartbeat configuration. To avoid reintroducing that flakiness (and to stay consistent with tests/conftest.py which sets heartbeat_interval=2), consider passing a small heartbeat_interval explicitly in this SSL connect call, or reintroducing a skip/xfail with a concrete stability condition if it’s still intermittent.
@pytest.mark.parametrize("address", [server_addresses_ssl_basic, server_addresses_ssl_client_auth])
def test_fetch_table_several_pages(table_name, address, drop_table_cleanup):
ssl_cfg = create_ssl_param(True, 'client.pem', 'client.pem', 'ca.pem')
with pyignite_dbapi.connect(address=address, timeout=10, **ssl_cfg) as connection:
with connection.cursor() as cursor:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmgodinho
approved these changes
Apr 10, 2026
Erixonich
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28504