Skip to content

IGNITE-28504 Remove mentions of IGNITE-26358 in code #7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isapego merged 1 commit into from
Apr 13, 2026
Merged

IGNITE-28504 Remove mentions of IGNITE-26358 in code #7967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/platforms/python/dbapi/tests/test_executemany.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
import pytest


# TODO: IGNITE-26358: Enable heartbeats in tests and add variant with batch_size 300 and 2000 once heartbeats are implemented
@pytest.mark.parametrize("batch_size", [1, 2, 10])
@pytest.mark.parametrize("batch_size", [1, 2, 10, 300, 2000])
def test_executemany_success(table_name, cursor, drop_table_cleanup, batch_size):
test_data = [(i, f'data_{i}') for i in range(batch_size)]

Expand Down
3 changes: 1 addition & 2 deletions modules/platforms/python/dbapi/tests/test_fetch_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,7 @@ def test_cursor_iterable(table_name, cursor, drop_table_cleanup):
TEST_PAGE_SIZE + 1,
TEST_PAGE_SIZE * 2,
TEST_PAGE_SIZE * 2 + 1,
# TODO: IGNITE-26358 Implement Heartbeats
# 8000,
8000,
])
def test_fetch_table_several_pages(table_name, cursor, drop_table_cleanup, rows_num):
create_and_populate_test_table(cursor, rows_num, table_name, 1000)
Expand Down
2 changes: 0 additions & 2 deletions modules/platforms/python/dbapi/tests/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ def test_connection_non_existing_cert():
assert err.match('(No such file or directory)|(no such file)')


# TODO: IGNITE-26358: Enable heartbeats in tests re-enable this test
@pytest.mark.skip(reason="Flaky while there are no heartbeats")
@pytest.mark.parametrize("address", [server_addresses_ssl_basic, server_addresses_ssl_client_auth])
def test_fetch_table_several_pages(table_name, address, drop_table_cleanup):
ssl_cfg = create_ssl_param(True, 'client.pem', 'client.pem', 'ca.pem')
Expand Down