IGNITE-28856 Fix ignite-extensions compilation after IGNITE-28727 and IGNITE-28819#357
Merged
Merged
Conversation
Contributor
Author
|
Verification run on
Reactor Summary |
shishkovilja
approved these changes
Jul 3, 2026
Contributor
Author
|
TeamCity RunAll for this PR: https://ci2.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/9173232?buildTab=dependencies Compared to the latest master run (build 9171512):
The remaining Aws_2/Rdd/Ml failures are identical on master and unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignite-extensions master fails to compile against the current ignite 2.19.0-SNAPSHOT due to two recent core changes, plus checkstyle violations failing the CI:
IgniteInternalCache(lockTxEntry,lockTxEntries,lockTxEntryAsync,lockTxEntriesAsync).HibernateCacheProxy(hibernate-ext) does not implement them.CU.affinityFieldNametoBinaryUtils, breaking a method reference inKafkaToIgniteMetadataUpdaterTest(cdc-ext).JmsStreamer(jms11-ext) andStringQuery(spring-data-ext) violate theAnnotationOnSameLinecheckstyle rule (@Overridenot on the same line with its target).Fix: delegating implementations of the four
lockTx*methods inHibernateCacheProxy(same pattern as the neighboring lock/lockAll delegates); the test switched toBinaryUtils::affinityFieldName; annotations reordered to the common codestyle.Verified: full reactor
clean test-compileBUILD SUCCESS; full reactorcheckstyle:check -Pcheckstyle— 0 violations in all 65 modules.https://issues.apache.org/jira/browse/IGNITE-28856