IGNITE-17645 Write lastSnpSeg into SnapshotMetadata - #10247
Merged
nizhikov merged 6 commits intoSep 23, 2022
Merged
Conversation
timoninmaxim
force-pushed
the
IGNITE-17645__snapshot_meta_wal
branch
2 times, most recently
from
September 16, 2022 12:13
4e705b7 to
199553a
Compare
timoninmaxim
force-pushed
the
IGNITE-17645__snapshot_meta_wal
branch
from
September 22, 2022 15:13
199553a to
2290a2f
Compare
nizhikov
reviewed
Sep 22, 2022
| List<Integer> grpIds, | ||
| Set<String> bltNodes, | ||
| Set<GroupPartitionId> pairs, | ||
| @Nullable Long lastSegIdx, |
Contributor
There was a problem hiding this comment.
It seems lastSegIdx can be null only when we read existing snapshot metadata from disk.
Member
Author
There was a problem hiding this comment.
It could be null if wal() is disabled by user while snapshot is creating.
nizhikov
reviewed
Sep 22, 2022
| /** | ||
| * @return Index of last WAL segment that contains data of snapshot. | ||
| */ | ||
| public Long lastSegIdx() { |
Contributor
There was a problem hiding this comment.
lastSegIdx can be null here.
nizhikov
reviewed
Sep 22, 2022
nizhikov
reviewed
Sep 23, 2022
nizhikov
reviewed
Sep 23, 2022
nizhikov
reviewed
Sep 23, 2022
nizhikov
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.