IGNITE-18945 Add an ability to extend control-utility with the new commands - #10576
Closed
alex-plekhanov wants to merge 5 commits into
Closed
IGNITE-18945 Add an ability to extend control-utility with the new commands#10576alex-plekhanov wants to merge 5 commits into
alex-plekhanov wants to merge 5 commits into
Conversation
alex-plekhanov
force-pushed
the
ignite-18945
branch
from
March 6, 2023 06:22
039354a to
b2704e6
Compare
petrov-mg
reviewed
Mar 9, 2023
| new CommandsProviderImpl().commands().forEach((k, v) -> cmds.put(k.toLowerCase(), v)); | ||
|
|
||
| if (!F.isEmpty(it)) { | ||
| for (CommandsProvider provider : it) { |
Contributor
There was a problem hiding this comment.
It seems useful to add logging of what exeternal commands were registered.
Contributor
Author
There was a problem hiding this comment.
There can be tools which parse the output of control.sh script and new unexpected output can break these tools. At least for "info" logging level. But we can use "debug" logging level.
petrov-mg
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.