Commit fe54ebd
IMPALA-5031: widen Thrift enum to placate UBSAN
This fixes an instance of undefined behavior in the end-to-end tests
in which an enum value is outside of the allowable values for that
enum according to the C++14 standard.
Representative backtrace:
exec/parquet/parquet-metadata-utils.cc:293:26: runtime error: load of
value 49, which is not a valid value for type 'Type::type'
#0 ParquetMetadataUtils::ValidateRowGroupColumn(
parquet::FileMetaData const&, char const*, int, int,
parquet::SchemaElement const&, RuntimeState*)
exec/parquet/parquet-metadata-utils.cc:293:26
#1 BaseScalarColumnReader::Reset(HdfsFileDesc const&,
parquet::ColumnChunk const&, int)
exec/parquet/parquet-column-readers.cc:1077:43
#2 HdfsParquetScanner::InitScalarColumns()
exec/parquet/hdfs-parquet-scanner.cc:1679:60
#3 HdfsParquetScanner::NextRowGroup()
exec/parquet/hdfs-parquet-scanner.cc:648:45
#4 HdfsParquetScanner::GetNextInternal(RowBatch*)
exec/parquet/hdfs-parquet-scanner.cc:437:45
#5 HdfsParquetScanner::ProcessSplit()
exec/parquet/hdfs-parquet-scanner.cc:353:21
#6 HdfsScanNode::ProcessSplit(vector<FilterContext> const&,
MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21
#7 HdfsScanNode::ScannerThread(bool, long)
exec/hdfs-scan-node.cc:415:7
#8 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::
$_0::operator()() const exec/hdfs-scan-node.cc:337:13
Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844
Reviewed-on: http://gerrit.cloudera.org:8080/13940
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>1 parent 521b152 commit fe54ebd
1 file changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
41 | 63 | | |
42 | 64 | | |
43 | 65 | | |
| |||
0 commit comments