Set max packet size to 256KiB for SshjTool#405
Set max packet size to 256KiB for SshjTool#405grkvlt wants to merge 2 commits intoapache:masterfrom grkvlt:fix/ssh-max-packet
Conversation
|
incubator-brooklyn-pull-requests #517 SUCCESS |
There was a problem hiding this comment.
would it make sense to have it as a configKey?
There was a problem hiding this comment.
Could do, yes. One of the SSH_BLAH keys?
There was a problem hiding this comment.
yeah, something like SSH_MAX_PACKET_SIZE, wdyt?
|
incubator-brooklyn-pull-requests #521 SUCCESS |
|
I made the default 256KiB but this could be changed to 32KiB to match existing behaviour? I think the buffer size will have an impact on the total heap used by Brooklyn, as it increases the required memory allocation per SSH session. If there are many entities, and thus many SSH connections, this could be an issue. We need to do some memory profiling runs before deciding on an appropriate setting for this value. |
|
Since this doesn't seem to resolve the underlying issue, I'm closing this. |
4 participants
Fix for BROOKLYN-106