Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

delete port forwarding when VM is deleted#469

Merged
asfgit merged 2 commits intoapache:masterfrom
aledsage:fix/delete-portForwarding-strike2
Jan 27, 2015
Merged

delete port forwarding when VM is deleted#469
asfgit merged 2 commits intoapache:masterfrom
aledsage:fix/delete-portForwarding-strike2

Conversation

@aledsage
Copy link
Copy Markdown
Contributor

@aledsage aledsage commented Jan 23, 2015

This includes commits from #468 - please review+merge that first.

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 23, 2015

incubator-brooklyn-pull-requests #692 FAILURE
Looks like there's a problem with this pull request

@aledsage aledsage force-pushed the fix/delete-portForwarding-strike2 branch from 33b94a8 to 5ea091f Compare January 23, 2015 20:58
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 23, 2015

incubator-brooklyn-pull-requests #696 FAILURE
Looks like there's a problem with this pull request

@aledsage aledsage mentioned this pull request Jan 26, 2015
Merged
@aledsage aledsage force-pushed the fix/delete-portForwarding-strike2 branch from 5ea091f to 6507550 Compare January 26, 2015 10:12
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 26, 2015

incubator-brooklyn-pull-requests #698 FAILURE
Looks like there's a problem with this pull request

@aledsage aledsage force-pushed the fix/delete-portForwarding-strike2 branch from 6507550 to 9680a02 Compare January 26, 2015 15:14
@asfbot
Copy link
Copy Markdown

asfbot commented Jan 26, 2015

incubator-brooklyn-pull-requests #703 SUCCESS
This pull request looks good

@nakomis
Copy link
Copy Markdown
Contributor

nakomis commented Jan 27, 2015

An additional test which creates two machines, releases one machine then checks if the port mappings for the other machine are still around would be nice. Other than that, LGTM, tests pass

@aledsage
PortForwarding: delete on JcloudsLocation.release
02d77d5 
- Adds JcloudsPortForwarderExtension.closePortForwarding
- Adds PortForwardManager.forgetPortMappings(publicIpId)
- Fix jcloudsSshMachineLocation.getSshHostAndPort()
- Replace JcloudsPortforwardingLiveTest with JcloudsPortForwardingStubbedLiveTest
@aledsage
jclouds port forwarding: add testReleaseVmDoesNotImpactOtherVms
e1b35c5
@aledsage aledsage force-pushed the fix/delete-portForwarding-strike2 branch from 9680a02 to e1b35c5 Compare January 27, 2015 13:12
@asfgit asfgit merged commit e1b35c5 into apache:master Jan 27, 2015
asfgit pushed a commit that referenced this pull request Jan 27, 2015
@aledsage
This closes #469
bcd39d5
@aledsage
Copy link
Copy Markdown
Contributor Author

aledsage commented Jan 27, 2015

Thanks @nakomis - I've rebased, then added a test for two VMs (ensuring that releasing first does not impact second). Merging.

@asfbot
Copy link
Copy Markdown

asfbot commented Jan 27, 2015

incubator-brooklyn-pull-requests #711 SUCCESS
This pull request looks good

@aledsage aledsage deleted the fix/delete-portForwarding-strike2 branch October 20, 2015 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aledsage @asfbot @nakomis @asfgit