Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

Conversation

@neykov
Copy link
Member

@neykov neykov commented May 29, 2015

Fix transformation of URL to file path - a good example why one shouldn't use string operations when converting between file path and URL.
Sample failure - https://builds.apache.org/job/incubator-brooklyn-pull-requests/1267/console

erifyHttps(brooklyn.launcher.BrooklynWebServerTest)  Time elapsed: 0.018 sec  <<< FAILURE!
java.lang.IllegalArgumentException: Unable to access URL brooklyn.webconsole.security.keystore.url: /home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests%402/usage/launcher/target/test-classes/server.ks
    at brooklyn.util.ResourceUtils.getResourceFromUrl(ResourceUtils.java:287)
    at brooklyn.util.ResourceUtils.checkUrlExists(ResourceUtils.java:484)
    at brooklyn.launcher.BrooklynWebServer.getLocalKeyStorePath(BrooklynWebServer.java:515)
    at brooklyn.launcher.BrooklynWebServer.createContextFactory(BrooklynWebServer.java:443)
    at brooklyn.launcher.BrooklynWebServer.start(BrooklynWebServer.java:373)
    at brooklyn.launcher.BrooklynWebServerTest.verifyHttps(BrooklynWebServerTest.java:115)

@asfbot
Copy link

asfbot commented May 29, 2015

incubator-brooklyn-pull-requests #1272 SUCCESS
This pull request looks good

@sjcorbett
Copy link
Contributor

Looks good.

@asfgit asfgit merged commit 6a466b8 into apache:master Jun 1, 2015
asfgit pushed a commit that referenced this pull request Jun 1, 2015
@neykov neykov deleted the fix/invalid-file-from-url branch October 22, 2015 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants