Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

sensors at riak cluster level and other minor tidies for riak and couchbase#701

Merged
asfgit merged 1 commit intoapache:masterfrom
ahgittin:riak-cluster-sensors
Jun 19, 2015
Merged

sensors at riak cluster level and other minor tidies for riak and couchbase#701
asfgit merged 1 commit intoapache:masterfrom
ahgittin:riak-cluster-sensors

Conversation

@ahgittin
Copy link
Copy Markdown
Contributor

@bostko hi can you review this?

@bostko
Copy link
Copy Markdown
Contributor

bostko commented Jun 19, 2015

Very good changes, thank you!
I tested the cluster avarage values with https://github.com/apache/incubator-brooklyn/blob/master/examples/simple-web-cluster/src/main/resources/brooklyn/demo/nodejs-riak-todo.yaml and it looks good

P.S. I think it would be better if changes in doStart and those for cluster stats were in separate commits

@asfbot
Copy link
Copy Markdown

asfbot commented Jun 19, 2015

incubator-brooklyn-pull-requests #1361 SUCCESS
This pull request looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if the Riak cluster tests were updated to assert that the NODE_PUTS_1MIN_PER_NODE etc are being populated (e.g. that the attribute is eventually non-null).

@aledsage
Copy link
Copy Markdown
Contributor

Looks good; would be nice to improve our test coverage for things like this (even if it is just that the attribute values are non-null). Merging this now.

@asfgit asfgit merged commit 33f1e49 into apache:master Jun 19, 2015
asfgit pushed a commit that referenced this pull request Jun 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants