sensors at riak cluster level and other minor tidies for riak and couchbase#701
Conversation
|
Very good changes, thank you! P.S. I think it would be better if changes in doStart and those for cluster stats were in separate commits |
|
incubator-brooklyn-pull-requests #1361 SUCCESS |
There was a problem hiding this comment.
Would be good if the Riak cluster tests were updated to assert that the NODE_PUTS_1MIN_PER_NODE etc are being populated (e.g. that the attribute is eventually non-null).
|
Looks good; would be nice to improve our test coverage for things like this (even if it is just that the attribute values are non-null). Merging this now. |
@bostko hi can you review this?