This repository was archived by the owner on Nov 12, 2025. It is now read-only.
Merged
Conversation
Contributor
There was a problem hiding this comment.
What exception could t.cancel(true) throw - is it just being cautious? No harm having the try-catch I guess.
Contributor
|
Have reviewed "prevent NPE due to applicationName being null" and the subsequent 3 commits. |
…e todo comments
…ledDWAC calling to that, and with new interfaces for the shared items (deploy effectors etc) so that ControlledDWAC is not a JavaWebAppSoftwareProcess
… service up), failing gracefully if it's not, with some helpers in Tasks and DynamicTasks
…, though still submitted externally which means they will not be run as part of queue), and allow them to have children: improves traceability in GUI when effector methods call other effector methods, they show up as children rather than background tasks (or worse, not even as background tasks); and support setting flags in TaskBuilder
…ts, and ensure data is cleared (nulled) for old map entries due to backbone bug (without this, sometimes blockingTask might show up as `TYPEOF undefined` when you inspect its JSON)
… the method call, the surrounding context -- this ensures that a programmatic call to invoke an effector will throw if it fails, that the effector task is added to any parent context, but as an inessential task so it does not fail the parent context. new tests for this are in BasicEffectorTest. the effect is particularly magnified when we attempt to add programmatically driven effector calls to the dynamic task context (so they show up in the gui). these are now marked inessential, which i think is right because the user is interacting programmatically, and as the caller they would typically get on the result and handle errors themselves. this largely preserves existing behaviour, apart from with the exception that effector method calls inside other effectors could previously fail without throwing, and now they throw. this mainly affected dynamic cluster which in some places relied on failures being silently ignored, e.g. in the resize effector call. this effector now reliably fails if the cluster does not resize. previously it would depend whether it was in a task or not. to preserve compatibility in that class as much as possible, some interface methods (non-effector) have had their signature changed. it was not clear why these were on the interface, so i have deprecated them there also.
… may be referencing an entity which has gone away
…isplay name, and don't set the display name to tasks, and give jobs useful toStrings in many places
… and cancel tasks on demotion
Contributor
Author
|
rebased, and add one OSX test fix. merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When things go really wrong, a lot more things also go wrong.
(NB this builds on #83 at present, so merge that first.)