-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize : seata-rm-datasource module code style #2062
Conversation
� Conflicts: � rm-datasource/src/main/java/io/seata/rm/datasource/sql/SQLVisitorFactory.java � rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java � rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoDeleteExecutor.java � rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoInsertExecutor.java � rm-datasource/src/main/java/io/seata/rm/datasource/undo/oracle/OracleUndoUpdateExecutor.java
…nished&insertUndoLog param-branchId rename
� Conflicts: � rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java � rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java � rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/OracleTableMetaCache.java
Codecov Report
@@ Coverage Diff @@
## develop #2062 +/- ##
==========================================
Coverage 54.36% 54.36%
Complexity 2467 2467
==========================================
Files 445 445
Lines 14755 14755
Branches 1737 1737
==========================================
Hits 8022 8022
Misses 5971 5971
Partials 762 762 |
@zjinlei resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, keep jdk related import classes at the forefront.
Received, I will fix this later. |
� Conflicts: � rm-datasource/src/main/java/io/seata/rm/datasource/PreparedStatementProxy.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* 'develop' of https://github.com/seata/seata: (125 commits) optimize: tcc module code style (apache#2103) refactor: change the package path of MySQL recognizer (apache#2125) optimize: fix query typo (apache#2176) refactor: add sql parser type druid as constant (apache#2156) test: enhance test coverage of seata common (apache#2170) optimize: gracefully close resources (apache#2139) Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151) chore:use serializer instead of codec (apache#2097) optimize: spring module code style (apache#2159) optimize: Add Dubbo compatibility (apache#2036) optimize : seata-rm-datasource module code style (apache#2062) bugfix: Saga report branch status incorrect when service retried succeed (apache#2145) optimize:optimize log specifications (apache#2146) bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113) refactor: create sql parser spi and a druid type sql parser (apache#1703) refactor: simplify to make seata-common more readable (apache#2038) feature: support FastThreadLocalContextCore (apache#2106) optimize: some typos (apache#2120) optimize: increase the oracle table meta cache code coverage (apache#2078) optimize: some typos (apache#2115) ... # Conflicts: # pom.xml
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews