Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support FastThreadLocalContextCore #2106

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

ph3636
Copy link
Contributor

@ph3636 ph3636 commented Dec 29, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #2106 into develop will increase coverage by 0.46%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2106      +/-   ##
============================================
+ Coverage      55.14%   55.6%   +0.46%     
- Complexity      2517    2524       +7     
============================================
  Files            447     447              
  Lines          14929   14922       -7     
  Branches        1768    1765       -3     
============================================
+ Hits            8233    8298      +65     
+ Misses          5930    5849      -81     
- Partials         766     775       +9
Impacted Files Coverage Δ Complexity Δ
...ata/tm/api/transaction/TransactionHookManager.java 85.71% <ø> (+5.71%) 6 <0> (ø) ⬇️
...java/io/seata/tm/api/GlobalTransactionContext.java 100% <100%> (ø) 6 <2> (ø) ⬇️
...a/io/seata/tm/api/transaction/TransactionInfo.java 95.23% <100%> (ø) 12 <0> (-1) ⬇️
...ain/java/io/seata/tm/TransactionManagerHolder.java 84.61% <100%> (ø) 4 <0> (ø) ⬇️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 73.33% <50%> (+2.36%) 19 <0> (ø) ⬇️
...ava/io/seata/tm/api/DefaultFailureHandlerImpl.java 75% <50%> (+2.27%) 6 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.03% <75%> (ø) 28 <0> (ø) ⬇️
...java/io/seata/tm/api/transaction/RollbackRule.java 92.85% <0%> (-7.15%) 14% <0%> (-1%)
...asource/sql/struct/cache/OracleTableMetaCache.java 76.53% <0%> (+70.4%) 12% <0%> (+9%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 089f2e7 into apache:develop Jan 2, 2020
@ph3636 ph3636 deleted the FastThreadLocalContextCore branch January 4, 2020 08:35
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits)
  optimize: tcc module code style (apache#2103)
  refactor: change the package path of MySQL recognizer (apache#2125)
  optimize: fix query typo (apache#2176)
  refactor: add sql parser type druid as constant (apache#2156)
  test: enhance test coverage of seata common (apache#2170)
  optimize: gracefully close resources (apache#2139)
  Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151)
  chore:use serializer instead of codec (apache#2097)
  optimize: spring module code style (apache#2159)
  optimize: Add Dubbo compatibility (apache#2036)
  optimize : seata-rm-datasource module code style (apache#2062)
  bugfix: Saga report branch status incorrect when service retried succeed (apache#2145)
  optimize:optimize log specifications (apache#2146)
  bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113)
  refactor: create sql parser spi and a druid type sql parser (apache#1703)
  refactor: simplify to make seata-common more readable (apache#2038)
  feature: support FastThreadLocalContextCore (apache#2106)
  optimize: some typos (apache#2120)
  optimize: increase the oracle table meta cache code coverage (apache#2078)
  optimize: some typos (apache#2115)
  ...

# Conflicts:
#	pom.xml
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants