Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the package path of MySQL recognizer #2125

Merged
merged 7 commits into from
Jan 13, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Move MySQL recognizer into io.seata.rm.datasource.sql.druid.mysql as same as Oracle.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #2125 into develop will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2125   +/-   ##
==========================================
  Coverage      54.42%   54.42%           
  Complexity      2469     2469           
==========================================
  Files            445      445           
  Lines          14742    14742           
  Branches        1734     1734           
==========================================
  Hits            8023     8023           
  Misses          5958     5958           
  Partials         761      761
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.92% <25%> (ø) 21 <0> (ø) ⬇️
...main/java/io/seata/core/store/db/LogStoreSqls.java 18.86% <50%> (ø) 10 <1> (ø) ⬇️

Copy link
Contributor

@long187 long187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added Do Not Merge Do not merge into develop and removed Do Not Merge Do not merge into develop labels Jan 3, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title refactor: change the path of MySQL recognizer as same as Oracle refactor: change the package path of MySQL recognizer Jan 13, 2020
@zjinlei zjinlei merged commit 167b745 into apache:develop Jan 13, 2020
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits)
  optimize: tcc module code style (apache#2103)
  refactor: change the package path of MySQL recognizer (apache#2125)
  optimize: fix query typo (apache#2176)
  refactor: add sql parser type druid as constant (apache#2156)
  test: enhance test coverage of seata common (apache#2170)
  optimize: gracefully close resources (apache#2139)
  Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151)
  chore:use serializer instead of codec (apache#2097)
  optimize: spring module code style (apache#2159)
  optimize: Add Dubbo compatibility (apache#2036)
  optimize : seata-rm-datasource module code style (apache#2062)
  bugfix: Saga report branch status incorrect when service retried succeed (apache#2145)
  optimize:optimize log specifications (apache#2146)
  bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113)
  refactor: create sql parser spi and a druid type sql parser (apache#1703)
  refactor: simplify to make seata-common more readable (apache#2038)
  feature: support FastThreadLocalContextCore (apache#2106)
  optimize: some typos (apache#2120)
  optimize: increase the oracle table meta cache code coverage (apache#2078)
  optimize: some typos (apache#2115)
  ...

# Conflicts:
#	pom.xml
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
@l81893521 l81893521 deleted the refactor_recognizer branch May 6, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants