-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add sql parser type druid as constant #2156
refactor: add sql parser type druid as constant #2156
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2156 +/- ##
=============================================
+ Coverage 54.39% 54.42% +0.03%
- Complexity 2469 2470 +1
=============================================
Files 445 445
Lines 14742 14742
Branches 1734 1734
=============================================
+ Hits 8019 8024 +5
+ Misses 5963 5957 -6
- Partials 760 761 +1
|
Could it be an enumeration class that put more sql parser types? |
How about an abstract class contains sql parser type constants? Because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We may need to move ConfigurationKeys to the common module.
Enumeration attributes are constants, so why not consider it? |
|
This can be considered. |
@slievrly |
Sorry, My low-level mistake. |
SqlParserType added. |
753a3ed
to
232f0bb
Compare
232f0bb
to
9c30d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'develop' of https://github.com/seata/seata: (125 commits) optimize: tcc module code style (apache#2103) refactor: change the package path of MySQL recognizer (apache#2125) optimize: fix query typo (apache#2176) refactor: add sql parser type druid as constant (apache#2156) test: enhance test coverage of seata common (apache#2170) optimize: gracefully close resources (apache#2139) Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151) chore:use serializer instead of codec (apache#2097) optimize: spring module code style (apache#2159) optimize: Add Dubbo compatibility (apache#2036) optimize : seata-rm-datasource module code style (apache#2062) bugfix: Saga report branch status incorrect when service retried succeed (apache#2145) optimize:optimize log specifications (apache#2146) bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113) refactor: create sql parser spi and a druid type sql parser (apache#1703) refactor: simplify to make seata-common more readable (apache#2038) feature: support FastThreadLocalContextCore (apache#2106) optimize: some typos (apache#2120) optimize: increase the oracle table meta cache code coverage (apache#2078) optimize: some typos (apache#2115) ... # Conflicts: # pom.xml
Ⅰ. Describe what this PR did
According to the last review comment in #1703, added sql parser type druid as constant.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews