Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix query typo #2176

Merged
merged 2 commits into from
Jan 13, 2020
Merged

optimize: fix query typo #2176

merged 2 commits into from
Jan 13, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

change wrong word "qurey" to "query"

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #2176 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2176      +/-   ##
=============================================
- Coverage      54.43%   54.42%   -0.02%     
+ Complexity      2471     2469       -2     
=============================================
  Files            445      445              
  Lines          14742    14742              
  Branches        1734     1734              
=============================================
- Hits            8025     8023       -2     
  Misses          5958     5958              
- Partials         759      761       +2
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/sqlparser/druid/DruidDbTypeParser.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ata/sqlparser/druid/DruidSQLRecognizerFactory.java 47.05% <ø> (ø) 2 <0> (ø) ⬇️
...in/java/io/seata/rm/datasource/util/JdbcUtils.java 87.5% <100%> (ø) 3 <0> (ø) ⬇️
.../io/seata/rm/datasource/sql/SQLVisitorFactory.java 80% <100%> (ø) 2 <1> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.13% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 47.26% <0%> (-0.4%) 27% <0%> (-1%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 59d7598 into apache:develop Jan 13, 2020
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits)
  optimize: tcc module code style (apache#2103)
  refactor: change the package path of MySQL recognizer (apache#2125)
  optimize: fix query typo (apache#2176)
  refactor: add sql parser type druid as constant (apache#2156)
  test: enhance test coverage of seata common (apache#2170)
  optimize: gracefully close resources (apache#2139)
  Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151)
  chore:use serializer instead of codec (apache#2097)
  optimize: spring module code style (apache#2159)
  optimize: Add Dubbo compatibility (apache#2036)
  optimize : seata-rm-datasource module code style (apache#2062)
  bugfix: Saga report branch status incorrect when service retried succeed (apache#2145)
  optimize:optimize log specifications (apache#2146)
  bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113)
  refactor: create sql parser spi and a druid type sql parser (apache#1703)
  refactor: simplify to make seata-common more readable (apache#2038)
  feature: support FastThreadLocalContextCore (apache#2106)
  optimize: some typos (apache#2120)
  optimize: increase the oracle table meta cache code coverage (apache#2078)
  optimize: some typos (apache#2115)
  ...

# Conflicts:
#	pom.xml
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
@l81893521 l81893521 deleted the fix_query_typo branch May 6, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants